Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_semantic): semantic model considering static init block as scope #4071

Merged
merged 2 commits into from
Dec 21, 2022
Merged

fix(rome_js_semantic): semantic model considering static init block as scope #4071

merged 2 commits into from
Dec 21, 2022

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Dec 18, 2022

Summary

This PR fix a hole in the semantic model scope that was not considering static init blocks.

Test Plan

> cargo test -p rome_js_semantic -- ok_scope_static_initialization_block
> cargo test -p rome_js_semantic -- ok_reference_static_initialization_block

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Dec 18, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit c091968
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/639f15319b4dc20008647280

@xunilrj xunilrj mentioned this pull request Dec 18, 2022
Merged
@ematipico ematipico merged commit 162c436 into main Dec 21, 2022
@ematipico ematipico deleted the fix/static-init-block-scope branch December 21, 2022 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xunilrj @ematipico