This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): fix useConst suggestion when some bindings cannot live inside const #4014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #4006
The real fix is at:
crates/rome_js_analyze/src/semantic_analyzers/nursery/use_const.rs
All the other changes were using some of the examples to better test semantic model and batch mutation with the cases of
useConst
.I also moved a lot of cases from valid to invalid and vice-versa.
The older version of
crates/rome_js_analyze/tests/specs/nursery/useConst/valid.jsonc.snap
incorrectly had some diagnostics. I also fixed that.Test Plan