Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): faster version of noArguments #3838

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Nov 23, 2022

Summary

Small performance improvement for noArguments.

> hyperfine "~/github/tools/target/release/rome check ~/github/vscode" "~/github/toolsmain/target/release/rome check ~/github/vscode" -i
Benchmark 1: ~/github/tools/target/release/rome check ~/github/vscode
  Time (mean ± σ):     661.1 ms ±   7.2 ms    [User: 8643.3 ms, System: 201.7 ms]
  Range (min … max):   649.0 ms … 673.3 ms    10 runs
 
  Warning: Ignoring non-zero exit code.
 
Benchmark 2: ~/github/toolsmain/target/release/rome check ~/github/vscode
  Time (mean ± σ):     722.4 ms ±   9.8 ms    [User: 9576.6 ms, System: 210.6 ms]
  Range (min … max):   710.3 ms … 745.3 ms    10 runs
 
  Warning: Ignoring non-zero exit code.
 
Summary
  '~/github/tools/target/release/rome check ~/github/vscode' ran
    1.09 ± 0.02 times faster than '~/github/toolsmain/target/release/rome check ~/github/vscode'

Test Plan

> cargo test -- no_arguments

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit ccea535
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637f74f7c5a1f600099f43e7

@xunilrj
Copy link
Contributor Author

xunilrj commented Nov 23, 2022

!bench_analyzer

@github-actions
Copy link

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.01      3.1±0.19ms     3.7 MB/sec    1.00      3.1±0.16ms     3.8 MB/sec
analyzer/index.js         1.00      7.6±0.45ms     4.3 MB/sec    1.00      7.6±0.33ms     4.3 MB/sec
analyzer/lint.ts          1.00      3.7±0.27ms    11.2 MB/sec    1.01      3.7±0.17ms    11.1 MB/sec
analyzer/parser.ts        1.04      9.1±0.48ms     5.4 MB/sec    1.00      8.7±0.41ms     5.6 MB/sec
analyzer/router.ts        1.00      3.8±0.19ms     9.1 MB/sec    1.00      3.7±0.19ms     9.1 MB/sec
analyzer/statement.ts     1.00      8.5±0.44ms     4.2 MB/sec    1.01      8.6±0.49ms     4.1 MB/sec
analyzer/typescript.ts    1.00     14.1±0.54ms     3.9 MB/sec    1.06     14.8±1.53ms     3.7 MB/sec

@xunilrj xunilrj force-pushed the feature/faster-no-arguments branch from b946b27 to ccea535 Compare November 24, 2022 13:43
@xunilrj xunilrj merged commit 7ee895e into main Nov 24, 2022
@xunilrj xunilrj deleted the feature/faster-no-arguments branch November 24, 2022 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants