Fix: return correct exit code on successful command execution #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
I noticed that this command was returning an exit code of 1 even when it completed successfully. This caused some unexpected behavior with monitoring tools such as Sentry cron monitoring which rely on the commands exit code to decide whether to trigger their
onSuccessoronFailurehandlers. Because of the non-zero exit code, these systems interpreted successful runs as failures and sent incorrect failure check-ins.This PR updates the command to return 0 on success, following the standard exit-code conventions. It’s a small change, but I thought it would be a nice improvement to help avoid misleading error reports in setups that monitor exit codes.
Thanks for maintaining this package! 🚀