Remove verbose configuration and replace it with log_filters
#615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Why? I would really, really like to set logging in configuration file. :( |
Owner
Author
|
You're right, let's replace it with a new configuration - to allow specify logging filters via https://docs.rs/env_logger/0.9.0/env_logger/struct.Builder.html#method.parse_filters. |
Contributor
|
Yeah, additional config option called |
Contributor
|
One more thing: it leaks internal structure of modules in the configuration by allowing to set filters per-module. I think it's fine but we should document that it's forever unstable and people should only set specific modules temporarily when we tell them during debugging. |
romanz
force-pushed
the
deprecate-verbosity
branch
2 times, most recently
from
db5bafb to
74935b2
Compare
Kixunil
reviewed
Nov 8, 2021
Please use `RUST_LOG` or `--log-filter` to specify logging verbosity. See https://github.com/env-logger-rs/env_logger/ for details.
Similar to `RUST_LOG` environment variable.
romanz
force-pushed
the
deprecate-verbosity
branch
from
08d93eb to
64bc7e1
Compare
romanz
changed the title
verbose configurationverbose configuration and replace it with log_filters
romanz
added a commit
to romanz/RaspiBolt
that referenced
this pull request
Nov 13, 2021
romanz
added a commit
to romanz/RaspiBolt
that referenced
this pull request
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use
RUST_LOGto specify logging verbosity.See https://github.com/env-logger-rs/env_logger/ for details.