Skip to content

Conversation

@romanz
Copy link
Owner

@romanz romanz commented Aug 15, 2021

Following #423

@Kixunil
Copy link
Contributor

Kixunil commented Aug 17, 2021

@romanz do you agree with waiting with this until at least one of these happens?

  • 0.9.1 release of electrs (assuming non-emergency)
  • Raspbian has rustc 1.48

@romanz
Copy link
Owner Author

romanz commented Aug 17, 2021

Definitely, thanks for the heads up!

@romanz romanz force-pushed the p2p-bullseye branch 5 times, most recently from 8a86f26 to f4d0042 Compare September 17, 2021 17:27
@romanz romanz added this to the 0.10 milestone Sep 17, 2021
@romanz romanz force-pushed the p2p-bullseye branch 2 times, most recently from 533876d to 43e2ecb Compare September 18, 2021 06:46
@romanz romanz deleted the branch master September 18, 2021 06:47
@romanz romanz closed this Sep 18, 2021
@Kixunil
Copy link
Contributor

Kixunil commented Sep 18, 2021

I'm not sure why other commits got mixed here, I believe MSRV bump was planned in 0.10, not 0.9? Also a nit, I think renaming the crate in Cargo.toml would have bean cleaner. (And easy to switch back if upstream version is sufficient.)

@romanz
Copy link
Owner Author

romanz commented Sep 18, 2021

I deleted p2p branch, and rebased p2p-bullseye over master - so I guess GitHub got confused...

@romanz romanz reopened this Sep 18, 2021
@romanz romanz changed the base branch from p2p to master September 18, 2021 09:08
@romanz romanz force-pushed the p2p-bullseye branch 2 times, most recently from 1fa6e0e to 3df9f2c Compare September 23, 2021 19:27
@romanz romanz force-pushed the p2p-bullseye branch 2 times, most recently from c7398ab to 2e04ee5 Compare October 6, 2021 18:36
@romanz
Copy link
Owner Author

romanz commented Oct 6, 2021

https://github.com/romanz/electrs/pull/455/checks?check_run_id=3818923414#step:7:90

 error: if let .. else expression looks like `matches!` macro
Error:    --> src/p2p.rs:260:5
    |
260 | /     if let Inventory::Block(_) = inv {
261 | |         true
262 | |     } else {
263 | |         false
264 | |     }
    | |_____^ help: try this: `matches!(inv, Inventory::Block(_))`

@Kixunil
Copy link
Contributor

Kixunil commented Oct 7, 2021

I think matches is available in 1.48. BTW I believe MSRV can (and IMO should) to be configured in clippy but I don't see it configured here.

@romanz romanz force-pushed the p2p-bullseye branch 3 times, most recently from a45ee9c to cee2c13 Compare October 11, 2021 11:03
@romanz romanz force-pushed the p2p-bullseye branch 2 times, most recently from 605cf89 to 9a10a21 Compare October 21, 2021 06:21
It still compiles on Rust 1.41.1 (with a few clippy warnings).

Also, move CI-related `Dockerfile` to `Dockerfile.ci`.
@romanz romanz removed this from the 0.10 milestone Oct 24, 2021
@romanz romanz changed the title Update MSRV to 1.48.0 and test on Debian 11 Support Rust 1.48.0 and test on Debian 11 Oct 24, 2021
@romanz
Copy link
Owner Author

romanz commented Oct 24, 2021

If there are no objections, I plan to merge it soon :)
@xanoni @openoms @AaronDewes @tehelsper @lukechilds

@romanz
Copy link
Owner Author

romanz commented Oct 24, 2021

BTW, we can still build electrs using Rust 1.41.1:

$ cargo +1.41.1 build --release

@AaronDewes
Copy link

Not sure about the other, but I'm using an even later rust & bullseye to build anyway.

@openoms
Copy link

openoms commented Oct 24, 2021

the later rust version is available for raspiblitz also, so will be built with the version set for cargo. No objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants