Fix failure to reset layout params to correct setting after dismiss is c... #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s complete. Bug: If layoutParams of dismissed view are WRAP_CONTENT, then this setting is overwritten with the original getHeight() of the View instead of returning to WRAP_CONTENT. This was breaking our list view cell's when they were being reused by the list view. They were no longer dynamically resizing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...omplete.
Bug: If layoutParams of dismissed view are WRAP_CONTENT, then this setting is overwritten with the original getHeight() of the View instead of returning to WRAP_CONTENT.
This was breaking our list view cell's when they were being reused by the list view. They were no longer dynamically resizing but were instead locked to 'originalHeight' forever after.