Add Additional Students Methods #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the `GetGroupsOfStudentAsync` and `GetSemestersOfStudentAsync` methods
- Allowed all users to access GET method `api/users/teachers`. - Allowed access to GET method `api/users/students` for teachers.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds additonal methods in
UsersControllerand applies policy changes from pull request #56.Added endpoints
api/users/students/[studentId]/groupsapi/users/students/[studentId]/semestersThese methods allows administrators and teachers unrestricted access. For other users, access is granted only if their user ID matches the requested ID. They do not validate
studentId(more information is available in swagger documentation).Changes made
ViewStudentEnrollmentsAuthorizationHandler.From pull request #56:
GET api/users/teachersmethod is now allowed for all registered users.GET api/users/studentsis now allowed for teachers and administrators.