Skip to content

Commit

Permalink
Adding support for TLS and http20 (Azure#5905)
Browse files Browse the repository at this point in the history
  • Loading branch information
panchagnula authored and yugangw-msft committed Apr 10, 2018
1 parent 44771ac commit cb5d3d4
Show file tree
Hide file tree
Showing 5 changed files with 226 additions and 187 deletions.
1 change: 1 addition & 0 deletions src/command_modules/azure-cli-appservice/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Release History
* (Breaking change): remove `assign-identity` which was tagged `deprecating` 2 releases ago
* webapp: capture the unhandled exception if the appservice plan doesn't exist
* `sdist` is now compatible with wheel 0.31.0
* webapp: az webapp config set support for min_tls_version & https2.0

0.1.30
++++++
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,8 @@ def load_arguments(self, _):
c.argument('java_version', help="The version used to run your web app if using Java, e.g., '1.7' for Java 7, '1.8' for Java 8")
c.argument('java_container', help="The java container, e.g., Tomcat, Jetty")
c.argument('java_container_version', help="The version of the java container, e.g., '8.0.23' for Tomcat")
c.argument('min_tls_version', help="The minimum version of TLS required for SSL requests, e.g., '1.0', '1.1', '1.2'")
c.argument('http20_enabled', help="configures a web site to allow clients to connect over http2.0.", arg_type=get_three_state_flag(return_label=True))
c.argument('app_command_line', options_list=['--startup-file'], help="The startup file for linux hosted web apps, e.g. 'process.json' for Node.js web")

with self.argument_context('webapp config backup') as c:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,8 @@ def update_site_configs(cmd, resource_group_name, name, slot=None,
remote_debugging_enabled=None, web_sockets_enabled=None, # pylint: disable=unused-argument
always_on=None, auto_heal_enabled=None, # pylint: disable=unused-argument
use32_bit_worker_process=None, # pylint: disable=unused-argument
min_tls_version=None, # pylint: disable=unused-argument
http20_enabled=None, # pylint: disable=unused-argument
app_command_line=None): # pylint: disable=unused-argument
configs = get_site_configs(cmd, resource_group_name, name, slot)
if linux_fx_version:
Expand All @@ -417,7 +419,7 @@ def update_site_configs(cmd, resource_group_name, name, slot=None,
import inspect
frame = inspect.currentframe()
bool_flags = ['remote_debugging_enabled', 'web_sockets_enabled', 'always_on',
'auto_heal_enabled', 'use32_bit_worker_process']
'auto_heal_enabled', 'use32_bit_worker_process', 'http20_enabled']
# note: getargvalues is used already in azure.cli.core.commands.
# and no simple functional replacement for this deprecating method for 3.5
args, _, _, values = inspect.getargvalues(frame) # pylint: disable=deprecated-method
Expand Down
Loading

0 comments on commit cb5d3d4

Please sign in to comment.