Repository navigation
Restructure the SCHISM notebooks into a tutorial and examples - #5
Open
rafa-guedes wants to merge 6 commits into
Open
rafa-guedes wants to merge 6 commits into
rafa-guedes wants to merge 6 commits into
Conversation
A mesh of the Perth coast made for the notebooks (make_mesh.py, from ETOPO 2022), TPXO9 tidal constituents as a pyTMD database (make_tides.py), ERA5 wind and pressure, GLORYS12 ocean reanalysis and WAVEWATCH III spectra, for early January 2023. About 3.4 MB.
Seven lessons, from a first tidal model to a tide and wind hindcast and its YAML configuration, run with the ghcr.io/rom-py/schism image and committed with their outputs.
Making a mesh, tidal and ocean boundaries, a baroclinic 3D model, waves with WWM, output, hotstarts, running SCHISM and friction sensitivity.
The previous notebooks used a downloaded fixture bundle and never ran SCHISM successfully. The README maps each of them to the notebooks that now cover it.
With SCHISM on the lesson template, the value-narrative and forcing-depth checks and the execution-contract marker no longer apply to any notebook, so they are removed.
- Rewrite the SCHISM learning tutorial page, overview and gallery section, and update the coverage matrix and concept-page links. - List the SCHISM data in data/example-data.json and remove the downloaded SCHISM fixture bundle, its acquisition script and the figures build that only executed the previous SCHISM notebooks. - Install rompy-schism from main, which needs the fixes the notebooks depend on. - The installation guide now lists the Docker images of all three models.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the SCHISM notebooks with a new collection in the same tutorial and examples layout as XBeach (#3) and SWAN (#4).
The collection
All notebooks model the coast off Perth in early January 2023. Every notebook that needs it runs SCHISM, and the results are committed.
notebooks/schism/tutorial/, 7 ordered lessons:param.nml), SCHISM's defaults and rompy-schism's checks;rompy run.notebooks/schism/examples/, 9 focused notebooks:notebooks/schism/data/, 3.4 MB committed:make_mesh.py);make_tides.py);It is listed in
data/example-data.json. TPXO is free for research and non-commercial use, as the data README says.notebooks/schism/README.mdis the index, including a table of where each previous notebook's content went.Removed
tutorial_01–07,schism_demo). They depended on a downloaded fixture bundle and did not run SCHISM successfully.scripts/schism_case_data.py,--acquire-schism).figuresdocs build and its CI step. It only executed those notebooks; the site is now built withmake docs-build, like the committed outputs of the other models.Site and tooling
rompy_notebooksmetadata on every notebook, the same convention as XBeach and SWAN.schism-tutorial.md,models/schism.md, the gallery, the coverage matrix and the concept-page links are updated.requirements.txtinstalls rompy-schism frommain. The notebooks need the rompy-schism fixes below; change it to a release once one is published.Dependencies in rompy-schism
The notebooks need these open PRs:
bctides.inis wrong for several boundary types, generated hotstarts are ignored, 3D models cannot be generated, and 3D boundary data has the wrong vertical profiles.ghcr.io/rom-py/schism:5.13.0, SCHISM with MPI, NetCDF, WWM andcombine_hotstart7. The notebooks use this image; it must be published and made public before the notebooks run for users.Checks
make docs-build(audit andmkdocs build --strict) passes.pytest testspasses.