This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
perf: add cached version of isDir
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukastaegert
suggested changes
May 10, 2019
keithamus
force-pushed
the
perf-add-cached-version-of-isdir
branch
from
2e3a623
to
d786f8d
Compare
| }; | ||
| const readFileCached = cache(readFileAsync); | ||
| const isDirCached = cache(file => statAsync(file).then(stat => stat.isDirectory(), ignoreENOENT)); | ||
| const isFileCached = cache(file => statAsync(file).then(stat => stat.isFile(), ignoreENOENT)); |
There was a problem hiding this comment.
Really nice now that I wrapped my head around it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cache
isFileandreadFile, but theresolvepackage also allows us to override theisDirfunction - which we can add our caching to to make performance better.