Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

#214 Add issue templates #217

Merged
merged 2 commits into from
May 10, 2019
Merged

#214 Add issue templates #217

merged 2 commits into from
May 10, 2019

Conversation

dima-takoy-zz
Copy link

Related to #214. Please, check, I don't know how issues templates work.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of this! Just added two things I noticed we might want to adapt.

👉 https://opencollective.com/rollup/donate
-->

- Rollup Version:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is for rollup-plugin-node-resolve, the plugin version would also be very important! How about

Node-Resolve Plugin Version:
Rollup Version:
Operating System (or Browser):
Node Version:



<!--
Most issues can be expressed or demonstrated through the REPL or a repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not really apply here as you do not have rollup-plugin-node-resolve in the REPL (after all, the REPL runs in the browser). Maybe we just change the first line to

<!--
  Most issues can be expressed or demonstrated through a repository.
  However ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity maybe Most issues can be expressed or demonstrated through a reproduction repository. However ... ?

Does it sound good in English? I don't know him very well, correct me if I suggested nonsense :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

@lukastaegert lukastaegert merged commit 6eb687b into rollup:master May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants