-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): Enforce prettier on CI #941
Conversation
Allow dynamically importing files in the same directory with an extra suffix before the extension.
and do not pass `--single-quote` to use the value in the config
because it will be loaded automatically given it's in the config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR title doesn't match the required format. The title should be in the conventional commit (https://www.conventionalcommits.org/en/v1.0.0-beta.4/) format. e.g.
chore(plugin-name): add pr title workflow
c33e948
to
1ae22f4
Compare
Thanks for opening this one! Very sorry I missed that. As soon as CI is done we'll merge. |
OK so we're getting a weird one:
I can reproduce this locally. However, when I run Diff looks like this: diff --git a/packages/dynamic-import-vars/CHANGELOG.md b/packages/dynamic-import-vars/CHANGELOG.md
index f8e17bf..219d285 100644
--- a/packages/dynamic-import-vars/CHANGELOG.md
+++ b/packages/dynamic-import-vars/CHANGELOG.md
@@ -69,4 +69,4 @@ _2020-08-13_
_2020-07-06_
-- First release
\ No newline at end of file
+- First release
Got it. CHANGELOG files weren't in the glob. |
Rollup Plugin Name:
na
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: #787
Description
Some changes that were in #787 and missed in the version in master.
At the moment on CI prettier is run with
--write
, meaning I think any error would not cause an issue because the files would also be 'fixed' on CI.With this PR we now enforce that prettier has been run on the files as they are in git, and also on every file type that prettier understands.
It also adds a few more extensions to the precommit hook, and removes the
--plugin
flag because it shouldn't be needed given the plugin is listed in the config file :)