Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-resolve: resolve symlinked entry point properly #291

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Mar 31, 2020

Rollup Plugin Name: node-resolve

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

The regression appeared here uuidjs/uuid#402 (comment)
after upgrading from rollup-plugin-node-resolve to @rollup/plugin-node-solve

Dependencies entry points are resolved into symlinked path when browser
field map contains real paths.

The regression appeared here uuidjs/uuid#402 (comment)
after upgrading from `rollup-plugin-node-resolve` to `@rollup/plugin-node-solve`

Dependencies entry points are resolved into symlinked path when browser
field map contains paths resolved into real paths.
@ctavan
Copy link
Contributor

ctavan commented Apr 3, 2020

Is there anything I can do to help get this one merged? Would be great to have it for my work over at uuid

@shellscape
Copy link
Collaborator

Patience :)

@shellscape shellscape merged commit 37db2a2 into master Apr 12, 2020
@shellscape shellscape deleted the node_resolve_symlinked_browser branch April 12, 2020 16:53
LarsDenBakker pushed a commit to LarsDenBakker/plugins that referenced this pull request Sep 12, 2020
The regression appeared here uuidjs/uuid#402 (comment)
after upgrading from `rollup-plugin-node-resolve` to `@rollup/plugin-node-solve`

Dependencies entry points are resolved into symlinked path when browser
field map contains paths resolved into real paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants