-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swc): initial release #1412
Conversation
We'll need to disambiguate this plugin from https://github.com/rollup/plugins/tree/master/packages/sucrase within the README for the plugin. Also lets get the rest of the PR template filled in. |
what do you mean by disambiguate the plugin? I don't really get the hint. You mean the missing issue number? |
@shellscape can you have a look again? Tests are running through now. |
That means using the readme to explain to people why they might use swc over sucrase, highlight differences, etc. This is a project where developer experience really matters, so when we're able to, it's good to give users info to make good choices. |
@shellscape You mean the root Readme.me of the whole rollup repository or? |
because this (swc) is the newest plugin, that info only needs to be in the readme for it. don't overthink 😺 |
@shellscape "Overthinker/Overthinking" is a word I hear not too rarely 🙈, but I like the feature and don't see it as a disadvantage My motive was to give the different transpilers the same treatment and that the respective audience aka viewers get the same overview of possible alternatives 😇. |
@shellscape it would really be great to release this as soon as possible ✌️ |
🙏 Please enhance your patience. This PR was put up 20 hours ago. I and the other maintainers will review when we're able to. General rule of thumb is to wait a week before pinging people. If you need to use this immediately you can publish the package to your own scope on NPM or use a symlink and workspace reference locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Few questions. Also please can you add a test that uses typescript?
i'm trying, but i'm also well aware that this is not one of my strengths 🙈 . |
@shellscape can you have a look ? |
@tjenkinson @dasa have your concerns beed addressed? |
@shellscape we disagree on this thread so could do with a tie breaker on there first other than that this LGTM :) |
I think we still disagree on the supported Node version. Discussed at: #1412 (review) |
Now that as far as I can survey, I think all concerns are resolved and we can complete the pull request @shellscape. |
@shellscape min rollup version set to v3+ and swc is now peer-dep again. I think that should be the end of it now v: |
@shellscape let me know if something is missing. |
@shellscape any news ? |
any news ? |
I would love to release it, but @shellscape has defined the policy that at least two other contributer/maintainer has approved the pull request. So unfortunately I have no choice but to wait :/ |
I think the concerns of @dasa and @tjenkinson have been resolved, maybe one of them will agree to give the last missing approval. Otherwise we have to wait for @shellscape ✌️ |
Rollup Plugin Name:
swc
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
#1413
Description