build(deps): update to latest rollkit #159

julienrbrt · 2025-06-25T13:29:41Z

Bumping again due to the breaking changes, which block my CI job https://github.com/rollkit/go-execution-abci/actions/runs/15877502173/job/44768669204?pr=150

Summary by CodeRabbit

Chores
- Updated internal dependencies to newer versions.
- Adjusted import sources for improved consistency.

gemini-code-assist

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the rollkit dependency to its latest version. This update is crucial for resolving breaking changes introduced in rollkit that were blocking the continuous integration (CI) pipeline, ensuring the project remains compatible and functional with the upstream rollkit developments.

Highlights

Dependency Update: The rollkit dependency and its sub-modules (core, da, sequencers/single) have been updated to a newer commit (6ad581a97a16). This update is critical for addressing breaking changes and unblocking the CI pipeline.
API Adaptation: The codebase has been adjusted to accommodate breaking changes in the rollkit API. Specifically, the import path for block-related utilities was changed from github.com/rollkit/rollkit/block to github.com/rollkit/rollkit/pkg/store, and corresponding constant usages were updated.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

coderabbitai · 2025-06-25T13:30:05Z

Walkthrough

The dependency for the github.com/rollkit/rollkit module and related submodules was updated to a new commit. Additionally, an import in the block RPC logic was adjusted to reference the correct package for a constant, updating both the import path and usage accordingly.

Changes

File(s)	Change Summary
go.mod	Updated `github.com/rollkit/rollkit` and its submodules to a new commit hash.
pkg/rpc/core/blocks.go	Changed import and usage of `DAIncludedHeightKey` from `block` to `storepkg`.

Possibly related PRs

build(deps): bump rollkit to latest #153: Updates the github.com/rollkit/rollkit module dependencies to newer commits, similar to this PR.
chore: upgrade rollkit to latest #98: Involves updating the github.com/rollkit/rollkit module and submodules, closely related to this dependency update.
chore: bump latest rollkit #115: Updates rollkit dependencies; related at the dependency update level.

Suggested reviewers

tac0turtle

Poem

Hopping through the code so bright,
Dependencies updated, everything’s right!
Imports aligned, no more fright,
The block’s new key is now in sight.
With every commit, we leap ahead—
A rabbit’s work, enough said! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8bbd403 and 572801c.

⛔ Files ignored due to path filters (1)

go.sum is excluded by !**/*.sum

📒 Files selected for processing (2)

go.mod (1 hunks)
pkg/rpc/core/blocks.go (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: lint / golangci-lint
GitHub Check: test / Run Unit Tests
GitHub Check: Test with Rollkit Chain

🔇 Additional comments (3)

go.mod (1)

32-35: LGTM! Dependency updates are consistent.

All rollkit modules have been consistently updated to the same commit hash 6ad581a97a16 dated 2025-06-25, which should resolve the breaking changes that were causing CI failures.

pkg/rpc/core/blocks.go (2)

16-16: LGTM! Import path updated correctly.

The import has been properly updated to reference the new package location for DAIncludedHeightKey constant, aligning with the rollkit dependency update.

110-110: LGTM! Usage updated to match new import.

The usage of DAIncludedHeightKey has been correctly updated to use the new package alias storepkg, maintaining consistency with the import change.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gemini-code-assist

Code Review

This pull request updates the rollkit dependency to a newer version, addressing breaking changes. The code modifications adapt to the updated dependency by changing an import path and the usage of a constant. I've provided suggestions to enhance code consistency by aligning the import alias for the rollkit/pkg/store package.

pkg/rpc/core/blocks.go

* main: test: add migration integration test + fix migration command (#150) build(deps): update to latest rollkit (#159) build(deps): bump rollkit to latest (#153) feat(server): add migration command (#113)

build(deps): update to latest rollkit

572801c

julienrbrt requested a review from a team as a code owner June 25, 2025 13:29

gemini-code-assist bot reviewed Jun 25, 2025

View reviewed changes

julienrbrt enabled auto-merge (squash) June 25, 2025 13:30

gemini-code-assist bot reviewed Jun 25, 2025

View reviewed changes

pkg/rpc/core/blocks.go Show resolved Hide resolved

pkg/rpc/core/blocks.go Show resolved Hide resolved

tac0turtle approved these changes Jun 25, 2025

View reviewed changes

julienrbrt merged commit 4c5a41d into main Jun 25, 2025
11 checks passed

julienrbrt deleted the julien/breaking branch June 25, 2025 13:37

coderabbitai bot mentioned this pull request Jun 27, 2025

chore: Bump rollkit version #168

Merged

coderabbitai bot mentioned this pull request Jul 9, 2025

build(deps): use tagged versions #180

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build(deps): update to latest rollkit #159

build(deps): update to latest rollkit #159

Uh oh!

julienrbrt commented Jun 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

build(deps): update to latest rollkit #159

build(deps): update to latest rollkit #159

Uh oh!

Conversation

julienrbrt commented Jun 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

coderabbitai bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

julienrbrt commented Jun 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)