Skip to content

Update install-go script #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 16, 2024
Merged

Update install-go script #375

merged 5 commits into from
May 16, 2024

Conversation

yarikbratashchuk
Copy link
Contributor

@yarikbratashchuk yarikbratashchuk commented May 14, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced Go installation scripts for easier customization with dynamic Go binary path setting.
  • Bug Fixes

    • Upgraded Go version to 1.22.3 for improved performance and security.

@yarikbratashchuk yarikbratashchuk self-assigned this May 14, 2024
@yarikbratashchuk yarikbratashchuk requested a review from jcstein May 14, 2024 15:19
Copy link
Contributor

coderabbitai bot commented May 14, 2024

Warning

Rate Limit Exceeded

@yarikbratashchuk has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 24 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between ad8325d and 9aa6dc6.

Walkthrough

The recent updates bring improvements to the Go installation process and the Go version constant. The install-go.sh script now utilizes a variable for the Go binary path, dynamically identifies the shell configuration file for updating PATH, and streamlines the download and extraction steps. Moreover, the Go version constant in constants.js has been incremented from 1.22.2 to go1.22.3.

Changes

File Change Summary
.vitepress/constants/constants.js
public/install-go.sh
Updated Go version constant from 1.22.2 to go1.22.3. Enhanced script with variable for Go binary path, dynamic shell config file detection, and refined paths for download and extraction.

🐰
In code's grand dance, a version's rise,
With paths refined, the script now flies.
Go's new home, in binaries we trust,
Dynamic paths, adjustments just.
A rabbit's cheer for updates bright,
In shell and script, our future's light.
🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented May 14, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-16 13:40 UTC

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 7228f09 and c796b07.
Files selected for processing (2)
  • .vitepress/constants/constants.js (1 hunks)
  • public/install-go.sh (6 hunks)
Additional Context Used
ShellCheck (6)
public/install-go.sh (6)

[info] 24-24: Double quote to prevent globbing and word splitting.


[style] 39-39: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


[info] 40-40: Double quote to prevent globbing and word splitting.


[style] 41-41: Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


[warning] 129-129: ShellCheck can't follow non-constant source. Use a directive to specify location.


[warning] 141-141: ShellCheck can't follow non-constant source. Use a directive to specify location.

Additional comments not posted (5)
.vitepress/constants/constants.js (1)

2-2: Go version updated to 1.22.3.

public/install-go.sh (4)

19-21: Define the Go binary path using a variable.


22-23: Update curl command to use -sSL for better handling of redirects and silent mode.


96-100: Update logic for adding the Go binary path to the shell configuration file.


112-114: Update logic for determining the appropriate shell configuration file.

@yarikbratashchuk yarikbratashchuk changed the title Put go binary under $HOME, add $HOME/go/bin to PATH Update install-go script May 14, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c796b07 and 23e1957.
Files selected for processing (1)
  • public/install-go.sh (4 hunks)
Files not reviewed due to errors (1)
  • public/install-go.sh (no review received)
Additional Context Used
ShellCheck (2)
public/install-go.sh (2)

[style] 40-40: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


[style] 42-42: Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 23e1957 and ad8325d.
Files selected for processing (1)
  • public/install.sh (1 hunks)
Additional Context Used
ShellCheck (1)
public/install.sh (1)

[info] 12-12: Double quote to prevent globbing and word splitting.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@jcstein jcstein merged commit e48c32b into main May 16, 2024
4 checks passed
@jcstein jcstein deleted the yarik/fix-go-install branch May 16, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants