Skip to content

DEMO PREVIEW Remove async script loading #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yarikbratashchuk
Copy link
Contributor

@yarikbratashchuk yarikbratashchuk commented May 10, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Removed the async attribute from the script tag that loads Twitter widgets to enhance compatibility and loading behavior.

@yarikbratashchuk yarikbratashchuk requested a review from jcstein May 10, 2024 15:02
Copy link
Contributor

coderabbitai bot commented May 10, 2024

Walkthrough

The recent update involves a small but significant tweak in the configuration of the VitePress project. Specifically, the async attribute has been removed from the script tag responsible for loading Twitter widgets, potentially altering how quickly these widgets load on the page.

Changes

File Change Summary
.vitepress/config.ts Removed async: true from Twitter widget script tag

Poem

🐇✨
In the garden of code, under the digital sky,
A small change was made, oh me, oh my!
No more async, in the script that we weave,
Let's hop to the rhythm, as the pages retrieve.
🌼🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented May 10, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-10 16:41 UTC

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 0a3b35e and 08e7b0e.
Files selected for processing (1)
  • .vitepress/config.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • .vitepress/config.ts

@yarikbratashchuk
Copy link
Contributor Author

@jcstein, weird.
Didn't help.

@jcstein
Copy link
Member

jcstein commented May 10, 2024

I wonder if it was just cached locally after the first load for you?

@jcstein jcstein marked this pull request as draft May 10, 2024 16:36
@yarikbratashchuk
Copy link
Contributor Author

no, it wasn't
i now don't see difference so, let's leave it as it is, closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants