-
Notifications
You must be signed in to change notification settings - Fork 57
style: change font to ubuntu #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe recent updates enhance the VitePress configuration and styling by optimizing font usage. Preconnect links for Google Fonts were added, and new stylesheet links for Ubuntu Mono and Ubuntu fonts were included. Additionally, custom root variables for font families were defined in the theme's CSS, and an obsolete sidebar link was removed. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@jcstein, shall we make it a pr, update branch and merge it? |
I'll update branch. I think this requires a little more weigh in, so let's check with @Manav-Aggarwal @gupadhyaya @tzdybal @tuxcanfly @MSevey to see what they think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .vitepress/config.ts (2 hunks)
- .vitepress/theme/style.css (1 hunks)
Files skipped from review due to trivial changes (1)
- .vitepress/theme/style.css
Additional comments not posted (3)
.vitepress/config.ts (3)
113-115
: Good use of preconnect to optimize font loading performance.
116-118
: Appropriate use of preconnect with crossorigin for better performance.
120-123
: Correctly added stylesheet link for Ubuntu and Ubuntu Mono fonts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .vitepress/config.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .vitepress/config.ts
i'm good with that |
closing after feedback at onsite |
Previews
Checklist
Summary by CodeRabbit
New Features
Improvements
Removals