esm imports created by rolldown don't remove the `node:` protocol when needed

[SuperchupuDev]

Reproduction link or steps

https://github.com/SuperchupuDev/tsdown-node-protocol-repro/blob/b16fb58

What is expected?

the following import generated by rolldown should have the node protocol removed, like this:

import { createRequire } from "module";

What is actually happening?

it fails to remove the node: protocol

import { createRequire } from "node:module";

Any additional comments?

someone opened a pr on fdir to switch to tsdown, thecodrr/fdir#147, and i suggested to use the removeNodeProtocol option to ensure compatibility with node 12. when testing locally i noticed there was one import that had it

[sxzz]

A current workaround is to call createRequire directly yourself, instead of using the polyfill.

[hyf0]

The workaround code looks like

https://bundler.sxzz.dev/#eNptjsGOwjAMRH/FyqW7UpW9h7/YMweixEGpkri4DlSq8u8UikAgJB8849HzLCoos6hYPM5apttelHnpXrlVMp5qZNSME6Uzri4qI1yx9YopJU+Xoh2VEI96eEK+XDYcziOxgMdgaxJY9gVgTFYCcTbQFfLY9TczlgGdmC0B8Khh4OCtWCM4y99gz3ZyHEfpY75jF3CMVvB/S0ODwJShy+Rrwm4HH+/f0j8bRGcUqyun393h3qTtyzqqtXYF1YVrVg==

[wChenonly]

It can also be temporarily resolved.

// tsdown.config.ts
export default defineConfig({
  onSuccess() {
    const distPath = join(__dirname, 'dist')
    const filePath = join(distPath, 'index.mjs')
    try {
      const content = readFileSync(filePath, 'utf8').replace(/node:/g, '')
      writeFileSync(filePath, content)
    } catch (error) {}
  }
})

[glen-cheney]

👋 this issue is resolved in tsdown, but I arrived here via Google search. I am using rollup-plugin-node-externals, which defaults to adding the node: protocol. So if you're trying to strip the node protocol, make sure you also use set the option in the plugin nodeExternals({ builtinsPrefix: 'strip' })