Skip to content

fix: fix configuration for older rolldown versions #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Joery-M wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix configuration for older rolldown versions #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions app/components/OutputContainer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
timeCost,
} from '~/state/bundler'
import { npmVfsFiles, userDependencies } from '~/state/npm'
import type { BuildOptions } from '@rolldown/browser'

const { data: rolldownVersions } = await useRolldownVersions()

Expand Down Expand Up @@ -57,7 +58,7 @@ const { data, status, error, refresh } = useAsyncData(
const configFile =
files.value.get(CONFIG_FILES[0]!) || files.value.get(CONFIG_FILES[1]!)
if (configFile) {
const { output } = await core.build({
const buildConfig: BuildOptions = {
input: `/${configFile.filename}`,
cwd: '/',
output: { format: 'cjs' },
Expand All @@ -66,7 +67,15 @@ const { data, status, error, refresh } = useAsyncData(
transform: {
define: { 'import.meta': 'importMeta' },
},
})
}

//@ts-expect-error This is for older Rolldown versions
buildConfig.define = {
'import.meta': 'importMeta',
// This is here for versions before https://github.com/rolldown/rolldown/pull/5378
'import.meta.input': 'importMeta.input',
}
const { output } = await core.build(buildConfig)
const configCode = output[0].code

if (configCode.trim()) {
Expand All @@ -83,6 +92,7 @@ const { data, status, error, refresh } = useAsyncData(
throw new Error(`Cannot import '${id}' in config file`)
}
const module = { exports: {} as any }
// Note: if you add properties here, also update the code above
const importMeta = { input: entries.value }
configFn(require, module, importMeta)

Expand Down