Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove uuid dependency #998

Merged
merged 2 commits into from
Mar 16, 2022
Merged

remove uuid dependency #998

merged 2 commits into from
Mar 16, 2022

Conversation

ijsnow
Copy link
Contributor

@ijsnow ijsnow commented Mar 15, 2022

Description of the change

This PR removes the uuid dependency. I began looking into the issue linked below and then realized that this SDK just uses a hand rolled uuid function.

Type of change

  • Maintenance

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

waltjones
waltjones approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ijsnow ijsnow merged commit 4bbe9fa into rollbar:master Mar 16, 2022
@ijsnow ijsnow deleted the update-uuid branch March 16, 2022 22:30
This was referenced Apr 15, 2022
Merged
Merged
Open
Merged
@renovate renovate bot mentioned this pull request Apr 24, 2022
Open
1 task
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
@ijsnow
Merge pull request #998 from ijsnow/update-uuid
d3aaf44 
remove uuid dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

@cyrusradfar cyrusradfar Awaiting requested review from cyrusradfar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UUID dependency is outdated
2 participants
@ijsnow @waltjones