feat: Support URL
object in fetch
/ XHR
telemetry
#1118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
At Fingerprint.js we have experienced several issues with our customers who use Rollbar. Some telemetry events weren't captured due to unsupported
URL
type infetch
/XHR
(see Parameter section - theURL
type is valid argument type forfetch
).I added support to rollbar
Instrumenter
and covered this behaviour with unit tests.fetch
andXHR
support any object with stringifier, so I can extend this condition to any object withtoString
method, thought it might be not really useful. Feel free to discuss the solutionType of change
Related issues
I didn't create particular issue for Rollbar, but It's similar to what had with Honeybadger: issue, PR
Checklists
Development
Code review