Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide this to closure #1081

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Provide this to closure #1081

merged 1 commit into from
Jan 4, 2023

Conversation

waltjones
Copy link
Contributor

Description of the change

Provides the outer this to the closure function. This affects Angular users.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes
#1080
https://app.shortcut.com/rollbar/story/120687/

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@waltjones waltjones changed the title Provide this to closure Provide this to closure Jan 4, 2023
mudetroit
mudetroit approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh javsascript...

@waltjones waltjones merged commit e2b98e0 into master Jan 4, 2023
@waltjones waltjones mentioned this pull request Jan 4, 2023
Merged
7 tasks
@renovate renovate bot mentioned this pull request Jan 6, 2023
Merged
1 task
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
@waltjones
provide this to closure (#1081)
03d559a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudetroit mudetroit mudetroit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waltjones @mudetroit