Refactor to use current (3.x) async package #1017
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The async package dependency needed to be updated from v1.x to 3.x to pick up a security update. There have been interface changes since then, so a small refactor was also needed to work with the current async interface.
The specific changes that affect rollbar.js happened in async v2.0.0:
https://github.com/caolan/async/blob/master/CHANGELOG.md#breaking-changes-1
This PR updates the calling convention for callbacks, and removes usage of
fs.exists
which is is both deprecated and incompatible with the current async interface.Type of change
Development
Code review