Support error cause #1012
Merged
Support error cause #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijsnow
approved these changes
Apr 5, 2022
| if (chromeMajorVersion() < 93) return; | ||
|
|
||
| it('should create trace_chain', function(done) { | ||
| var causeErr = new Error('cause error'); |
There was a problem hiding this comment.
I know all old tests use the old var syntax but is there a reason to continue using them as opposed to const/let?
There was a problem hiding this comment.
Just consistency. I'd rather not have a mix until we're actually switching over to const/let.
This was referenced Apr 15, 2022
1 task
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds support for the Error cause option enabled in Node 16.9, Chrome 93, and other browsers. (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error#browser_compatibility)
This PR leaves the existing
Error.nestedfunctionality for back compatibility with existing Rollbar.js usage and with earlier Node and browser versions. WhenError.nestedis present, it is preferred, preserving existing behavior.Type of change
Related issues
Fixes #1010
Development
Code review