Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSP listener on document, not window #1007

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

waltjones
Copy link
Contributor

Description of the change

Adding the securitypolicyviolation listener to the window object works on some browsers, including chrome, and headless chrome used in the tests. However, it doesn't work on Safari, and the spec requires it to be added to the document object, not the window object. https://developer.mozilla.org/en-US/docs/Web/API/SecurityPolicyViolationEvent

This PR adds the listener to the document instead of the window.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes #978

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request

Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSP not logging in Safari
2 participants