Add CSP listener on document, not window #1007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adding the
securitypolicyviolation
listener to the window object works on some browsers, including chrome, and headless chrome used in the tests. However, it doesn't work on Safari, and the spec requires it to be added to the document object, not the window object. https://developer.mozilla.org/en-US/docs/Web/API/SecurityPolicyViolationEventThis PR adds the listener to the document instead of the window.
Type of change
Related issues
Fixes #978
Development
Code review