Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LocalsSettings type #1004

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Fix LocalsSettings type #1004

merged 1 commit into from
Mar 17, 2022

Conversation

waltjones
Copy link
Contributor

Description of the change

The type declaration for LocalsSettings has a wrong key name. Fixing this won't break any existing clients, since the code that reads this object doesn't support using the wrong key name.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes: #989

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Copy link
Contributor

@ijsnow ijsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollbar.init() not accept "module" option field when use locals
3 participants