update dSYM upload script #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ezarowny looks good to me, my only comment would be to remove the identifier variable because it's not in use anymore, as well as the command to pull that out of info.plist file. |
the dSYM upload script now uses PRODUCT_BUNDLE_IDENTIFIER to find the project's main plist file
ezarowny
force-pushed
the
update-upload-dysm
branch
from
6ab7a23
to
dbe154a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the dSYM upload script now uses PRODUCT_BUNDLE_IDENTIFIER to find the project's main plist file