Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash fix #15

Merged
merged 1 commit into from
Jun 29, 2015
Merged

Crash fix #15

merged 1 commit into from
Jun 29, 2015

Conversation

newyorkpizza
Copy link
Contributor

Add a nil check since the following functions pass message=nil down to buildPayloadBodyWithMessage

  • [Rollbar logWithLevel:data:]
  • [Rollbar debugWithData:]
  • [Rollbar infoWithData:]
  • [Rollbar warningWithData:]
  • [Rollbar errorWithData:]
  • [Rollbar criticalWithData:]
  • [RollbarNotifier logCrashReport:]

@newyorkpizza
Handle nil parameter to avoid crashing, since several functions (e.g.…
d367f42 
… -[Rollbar infoWithData:]) call this method with a nil `message`.
@newyorkpizza
Copy link
Contributor Author

@coryvirok Hi Cory -- I hit this issue when trying to use the SDK. What do you think of the fix?

@coryvirok
Copy link
Contributor

Thanks for the PR. LGTM.

coryvirok added a commit that referenced this pull request Jun 29, 2015
@coryvirok
Merge pull request #15 from newyorkpizza/crashFix
6dca72c 
Crash fix
@coryvirok coryvirok merged commit 6dca72c into rollbar:master Jun 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newyorkpizza @coryvirok