Add Rubocop config #379
Merged
Add Rubocop config #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2016 12:37
Since we are still supporting Ruby 1.8, I've added disabled some settings so we don't have errors on them. LineLength is set to 1000 for now, since we have lot of long lines. Once we do a first work fixing the style we can then enable it and be focus on long lines Style/DoubleNegation is disabled as a personal preference :D vendor/** and gemfiles/vendor** are excluded [branch #2981]
jondeandres
force-pushed
the
jon/2981/add-rubocop-config
branch
from
ccdd975
to
8540091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are still supporting Ruby 1.8, I've added disabled some
settings so we don't have errors on them.
LineLength is set to 1000 for now, since we have lot of long lines. Once
we do a first work fixing the style we can then enable it and be focus
on long lines
Style/DoubleNegation is disabled as a personal preference :D
vendor/* and gemfiles/vendor* are excluded
[branch #2981]