Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored errors raised in ActiveJob are reported to Rollbar #531

Closed
morgoth opened this issue Sep 20, 2016 · 1 comment
Closed

Ignored errors raised in ActiveJob are reported to Rollbar #531

morgoth opened this issue Sep 20, 2016 · 1 comment

Comments

@morgoth
Copy link
Contributor

morgoth commented Sep 20, 2016

I have config:

Rollbar.configure do |config|
  config.exception_level_filters.merge!(
    "ApplicationJob::FrequentFailureError" => "ignore"
  )
end

which is not respected in AJ jobs (where they are raised)

I believe this is because (from readme):

This behavior applies to uncaught exceptions, not direct calls to Rollbar.error(), Rollbar.warning()

and in AJ plugin there is

Rollbar.error(exception, :job => self.class.name, :job_id => job_id)

which is a direct call.

I would expect this filtering work in AJ as well.

@jondeandres
Copy link
Contributor

Hey @morgoth, you are right. We should be using this:

Rollbar.error(exception,
                      :job => self.class.name,
                      :job_id => job_id,
                      :use_exception_level_filters => true)

We'll fix this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants