Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cocoapods issue when using RollbarCrash as an internal dependency #323

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Jul 25, 2023

Description of the change

This PR fixes an issue with our RollbarReport podspec where RollbarCrash wouldn't compile when targeting macOS (all other OS work fine) since cocoapods was duplicating headers during linting because god knows why, and this fixes it because whatever.

Related to

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

  • Not tracked

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jul 25, 2023
Copy link

@nieblara nieblara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INB4 the slack!

@matux matux merged commit af940af into master Jul 25, 2023
1 check passed
@matux matux deleted the ih8cocoapods branch July 25, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants