Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXArchInfo/NXGetLocalArchInfo is deprecated since watchOS 8.0 #322

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Jul 25, 2023

Description of the change

This PR prevents usage of deprecated/no longer supported mach-o/arch.h functions on watchOS that could potentially prevent App/Mac/Catalyst Store submissions from passing through:

RollbarCrash/RollbarNotifier/Sources/RollbarCrash/Util/RollbarCrashCPU.c:41:34: warning: 'NXGetLocalArchInfo' is deprecated: first deprecated in watchOS 8.0 [-Wdeprecated-declarations]

/Applications/Xcode.app/Contents/Developer/Platforms/WatchSimulator.platform/Developer/SDKs/WatchSimulator9.4.sdk/usr/include/mach-o/arch.h:72:26: note: 'NXGetLocalArchInfo' has been explicitly marked deprecated here

RollbarCrash/RollbarNotifier/Sources/RollbarCrash/Util/RollbarCrashCPU.c:41:11: warning: 'NXArchInfo' is deprecated: first deprecated in watchOS 8.0 - No longer supported [-Wdeprecated-declarations]

/Applications/Xcode.app/Contents/Developer/Platforms/WatchSimulator.platform/Developer/SDKs/WatchSimulator9.4.sdk/usr/include/mach-o/arch.h:58:27: note: 'NXArchInfo' has been explicitly marked deprecated here

Related

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

  • Not being tracked

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux added bug Something isn't working Ready for review labels Jul 25, 2023
@matux matux self-assigned this Jul 25, 2023
Copy link

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matux matux merged commit 4d94a4c into master Jul 25, 2023
1 check passed
@matux matux deleted the depr_watch branch July 25, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants