Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UTF8 character encoding issue when retrieving persisted payloads #319

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Jul 24, 2023

Description of the change

This PR fixes a character encoding issue when retrieving persisted payloads where strings weren't being read as UTF8 resulting in garbled strings.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jul 24, 2023
@shortcut-integration
Copy link

@matux matux merged commit 9cc4ff6 into master Jul 24, 2023
1 check passed
@matux matux deleted the encoding_bug branch July 24, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants