Skip to content

Dmilgram/invalid sources - raise custom error#6

Merged
ddmilgram merged 3 commits intomasterfrom
dmilgram/invalid-sources-raise-error
Mar 7, 2025
Merged

Dmilgram/invalid sources - raise custom error#6
ddmilgram merged 3 commits intomasterfrom
dmilgram/invalid-sources-raise-error

Conversation

@ddmilgram
Copy link

@ddmilgram ddmilgram commented Mar 6, 2025

Description of the change

We are seeing this Rollbar issue due to invalid source maps with non string values inside the sources array. So from our fork we want to raise a custom error that will be handled from the mox side, letting the user know about their wrong sourcemap.

image

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

this Rollbar issue

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@ddmilgram ddmilgram changed the title Dmilgram/invalid sources raise error Dmilgram/invalid sources - raise custon error Mar 6, 2025
@ddmilgram ddmilgram changed the title Dmilgram/invalid sources - raise custon error Dmilgram/invalid sources - raise custom error Mar 6, 2025
Copy link
Member

@brianr brianr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@brianr brianr removed their assignment Mar 6, 2025
@ddmilgram ddmilgram merged commit 29373a2 into master Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants