Upgrade projects to netstandard 2.0 #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multitargeting the main rollbar package to net452 & netstandard2
Contributor
Author
|
Since it seems rollbar is just ignoring PRs, for anyone interested, I forked this here and released it as Archon.Rollbar. |
rokob
suggested changes
Oct 18, 2017
Contributor
rokob
left a comment
rokob
left a comment
There was a problem hiding this comment.
Changes look good to me, except the versioning
appveyor.yml
Outdated
| @@ -1,9 +1,8 @@ | |||
| version: '0.3.0.{build}' | |||
| assembly_info: | |||
| version: '1.0.0.{build}' | |||
Contributor
There was a problem hiding this comment.
We aren't going from 0.3 to 1.0
Contributor
Author
There was a problem hiding this comment.
What should the version be? I was trying to follow semver to indicate a major change. However, since it is still targeting net452, maybe that isn't warranted. 0.4.0?
Contributor
|
I wouldn't say ignoring, just didn't get back around to this until now. Sorry it took so long. If we can work out the issue with the version number then this looks good to me. |
Contributor
|
Yeah let's go to 0.4.0 |
Only a minor release from v0.3.0
rokob
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multitargeting the main rollbar package to
net452&netstandard2. This will allow package consumers to build using .net core without warnings.