Makefile,spec: don't compress the man-page #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package managers like to compress man-pages on their own, because the type of compression for man-pages is user-configurable. In particular, Gentoo [1] doesn't want packages to compress their man-pages. Gentoo Portage has workarounds for this, but this is not specified in Package Manager Specification and results in extra compression-decompression pass. RPM also compresses man-pages itself (in `brp-compress`) (and similarly recompresses them as needed) rather than relying on packages to install compressed man-pages. Automake can handle installation of man-pages without the explicit "install" target, so use the standard automake-provided way of installing man-pages. It's also smart enough to package `nload.1.in` automatically. Don't specify an explicit man-page extension in .spec file as recommended by Fedora. [1] gentoo/gentoo#9543 (comment)
ahippo
added a commit
to ahippo/gentoo
that referenced
this pull request
Aug 26, 2018
As pointed out by @mgorny [1], packages should not compress their man pages on their own. Instead, Portage needs to handle the compression. Currently, `ecompressdir` is smart enough to recompress the man-pages as needed. However, this is not a fully PMS-compliant behavior. So, patch the Makefile.am not to compress the man-page. A corresponding pull request is submitted upstream [2]. [1] gentoo#9543 (comment) [2] rolandriegel/nload#4
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Aug 26, 2018
As pointed out by @mgorny [1], packages should not compress their man pages on their own. Instead, Portage needs to handle the compression. Currently, `ecompressdir` is smart enough to recompress the man-pages as needed. However, this is not a fully PMS-compliant behavior. So, patch the Makefile.am not to compress the man-page. A corresponding pull request is submitted upstream [2]. [1] #9543 (comment) [2] rolandriegel/nload#4 Closes: #9543
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package managers like to compress man-pages on their own,
because the type of compression for man-pages is user-configurable.
In particular, Gentoo [1] doesn't want packages to compress their man-pages.
Gentoo Portage has workarounds for this,
but this is not specified in Package Manager Specification and
results in extra compression-decompression pass.
RPM also compresses man-pages itself (in
brp-compress)(and similarly recompresses them as needed)
rather than relying on packages to install compressed man-pages.
Automake can handle installation of man-pages without the explicit "install" target,
so use the standard automake-provided way of installing man-pages.
It's also smart enough to package
nload.1.inautomatically.Don't specify an explicit man-page extension in .spec file as recommended by Fedora.
[1] gentoo/gentoo#9543 (comment)