Only use variant for ad tracking, return HLS master manifest for video playback #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using simple adapter for VOD playback, the returned "playURL" was a single variant of the master manifest, and thus would lose captions information and the ability to switch variants based on network speed.
The variant is still needed to track the ad, but the video node should still get the master playlist for HLS to work correctly.
I also bumped the version number to indicate a change.
@LockChristian @smathairoku is there a reason the library doesn't have indentation? It is very hard to read without any formatting. Could I open a PR with the file formatted (using the VS-code extension formatter)?