Review notes #1 - cdmihai

- remaing local variable
rokonec · Aug 5, 2021 · 3a4dc9f · 3a4dc9f
1 parent 04a1a67
commit 3a4dc9f
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/Build/BackEnd/BuildManager/BuildManager.cs b/src/Build/BackEnd/BuildManager/BuildManager.cs
@@ -1563,26 +1563,26 @@ private void HandleSubmissionException(BuildSubmission submission, Exception ex)
                 }
             }
 
-            bool setFaultedResult;
+            bool submissionNeedsCompletion;
             lock (_syncLock)
             {
                 // BuildRequest may be null if the submission fails early on.
-                setFaultedResult = submission.BuildRequest != null;
-                if (setFaultedResult)
+                submissionNeedsCompletion = submission.BuildRequest != null;
+                if (submissionNeedsCompletion)
                 {
                     var result = new BuildResult(submission.BuildRequest, ex);
                     submission.CompleteResults(result);
                 }
             }
 
-            if (setFaultedResult)
+            if (submissionNeedsCompletion)
             {
                 WaitForAllLoggingServiceEventsToBeProcessed();
             }
 
             lock (_syncLock)
             {
-                if (setFaultedResult)
+                if (submissionNeedsCompletion)
                 {
                     submission.CompleteLogging();
                 }