Code samples in light mode have poor color contrast

[aerovulpe]

Hi,

Thanks, @rohit-gohri for this awesome tool and being really helpful.

I have noticed an issue that I'm not sure is known.

The light mode theme makes it hard to read the text inside code samples.

Thanks again for all your help.

[aerovulpe]

Looking at the CSS, this is caused by background-color: var(--ifm-background-color); when --ifm-background-color is a light color. Which makes sense for a light theme.

[kimsauce]

I am seeing this issue as well

[rohit-gohri]

Can you provide a openapi yaml that has code samples (even better would be a PR to add it to examples) ? So I can reproduce it

[aerovulpe]

Hey @rohit-gohri , the OpenAPI YAML specification used for the multi-file YAML example has code samples.

I've created a commit replicating this in the example app by setting the --ifm-background-color theme variable to a light color for the light theme.

Here's the commit: ChatKitty@196523b

The screenshot is /examples/using-multi-file-yaml/#tag/pet/operation/addPet of the website example project running on that commit.

[rohit-gohri]

the OpenAPI YAML specification used for the multi-file YAML example has code samples.

Thanks, forgot about this 🤦

Can you test the fix by installing redocusaurus@v0.0.0-test-20220711040249 ?

[aerovulpe]

Thanks, @rohit-gohri!

I have installed redocusaurus@v0.0.0-test-20220711040249 and confirmed that it fixes this. 👍

[rohit-gohri]

Released in https://github.com/rohit-gohri/redocusaurus/releases/tag/v1.2.3