Generate all enhanced leaf texts on route change, store with jotai atom #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te. Use in wrapped leaf. tests: location from state.router.location
This was referenced Oct 21, 2024
… should get tooltips
…egistry and @plone/components
mauritsvanrees
approved these changes
Oct 24, 2024
ksuess
deleted the
calculate-enhanced-text-on-route-change---store-with-jotai
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New concept: Instead of generating the tooltip enhanced markup in each Slate leaf,
we generate all tooltip enhanced leaf texts on route change, store them with jotai atom and use the appropriate ones in the leafs.
New option 'show tooltips only on first occurrences on a page'