Skip to content

Added save screenshot method #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rpapallas
Copy link
Contributor

to allow clients to programmatically save screenshots to a desired path.

@rohanpsingh
Copy link
Owner

Thanks for the PR. I have a few comments:

  • The save_screenshot method should probably only return the image as an array. Writing should be handled by the user code.
  • I am planning to implement a record video functionality soon. Then I may have a better idea on how to best integrate both these features.
  • I'm afraid that adding too many new API calls that the user has access to would require a much better documentation than what we have now. The code would probably also need to be refactored to clarify which methods are meant for the user.

It should be safe to merge this though, but let me first implement the record video functionality .

@rpapallas
Copy link
Contributor Author

I agree, you might want to look into readthedocs for publishing docs, which you can publish as a GitHub page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants