Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: No need to wrap each word with literals 🥇 #34

Merged
merged 4 commits into from
Dec 19, 2023
Merged

feat: No need to wrap each word with literals 🥇 #34

merged 4 commits into from
Dec 19, 2023

Conversation

FirdousNath
Copy link
Collaborator

Status

READY

Description

  • Changed core logic of parsing keeping time complexity O(n)
  • Added functionality to add literals with regular strings
  • Now no need to wrap each word with literals.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@rohanjsh
Copy link
Owner

Fixes #29

@rohanjsh
Copy link
Owner

rohanjsh commented Dec 19, 2023

LGTM,
Great work @FirdousNath really appreciate it. I was unable to take out time to work on this.
Merging it in feat/breaking-2.0 for now. Will test it once, ensure ci checks and then will deploy.

Thanks much.

@rohanjsh rohanjsh changed the base branch from main to feat/breaking-2.0 December 19, 2023 04:59
@rohanjsh rohanjsh changed the title No need to wrap each word with literals 🥇 feat: No need to wrap each word with literals 🥇 Dec 19, 2023
@rohanjsh rohanjsh added the enhancement New feature or request label Dec 19, 2023
@rohanjsh rohanjsh merged commit fd19ef6 into rohanjsh:feat/breaking-2.0 Dec 19, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants