Skip to content

Commit

Permalink
Point to BSK branch with NetP observer improvements (duckduckgo#1894)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/0/1205210093476964/f
Tech Design URL:
CC:

Description:

For NetP Update Status View to match designs, I planned to rely on the shared Observer types to receive events from the PacketTunnnelProvider and other NetP types. However, on doing this, I noticed that we’re exposing the Subject type in order to synchronously access the most recent state.

Exposing these types as it means these events can be sent from anywhere and not just the source of the events. Rather than letting dependency on this propagate into iOS too, I decided to do a quick refactor to clean it up.

Additionally, I’ve created the associated mock types which I will also need throughout the iOS: Network Protection MVP TestFlight build for internal testing project. I decided now was the right time to create them as these types have been altered.

Creating the MockTunnelController is included in this task though it seems somewhat independent. This is so that it can be included in the same BSK release as it will also be needed for the parent task.

On iOS this is just a version bump for now to simplify the BSK release process.
  • Loading branch information
graeme authored Aug 9, 2023
1 parent 9bb349a commit ca36a9e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -8379,7 +8379,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 72.1.0;
version = 73.0.0;
};
};
C14882EB27F211A000D59F0C /* XCRemoteSwiftPackageReference "SwiftSoup" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"repositoryURL": "https://github.com/DuckDuckGo/BrowserServicesKit",
"state": {
"branch": null,
"revision": "dee5c815afe37bd82c48408c41646ad5af5b24e7",
"version": "72.1.0"
"revision": "b01e0010c7c0618f7329184c11c85a3c64a4307f",
"version": "73.0.0"
}
},
{
Expand Down

0 comments on commit ca36a9e

Please sign in to comment.