-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (Basic) getter methods for the v8 value struct #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rogchap
changed the title
Add getter methods for the v8 value struct
Add (Basic) getter methods for the v8 value struct
Jan 13, 2021
tmc
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! We should consider issues for the bigInt and object implementations. I like the fmt.Formatter support addition.
This was referenced Jan 14, 2021
@tmc Thanks. I've added those two issues as suggested. ☝️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable getting of richer data types from the v8 value struct than just currently
string
All the basic
ToXXX
methods have been implemented as defined here:https://v8.github.io/api/head/classv8_1_1Value.html#a838af7d16f0ce87b4411beb178383db4
However
ToBigInt()
andToObject()
have NOT yet been implemented. The reason is thatObject
represents everything that is not a primitive type: eg. Functions, Objects, Promises, Dates, Regex etc. Implementing all of theObject
type would make this PR too large, and take quite a bit of time to implement.Was hoping to include this PR in the next release, which already has a number of features people are waiting for to be released.
As such, I think it's best to un-export these methods (to not break the public API), get this PR merged, do a release and continue work on
Object
(andBigInt
) in later PRs.