Run v8 python script in a separate subshell #228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
build/deps.py was trying to import a script from v8, in a way that isn't python3 compatible, since there aren't init.py files in the directories on the path to the script
Solution
Use a separate command to execute the script, which is the way this is done in v8 as well (https://github.com/v8/v8/blob/ee74e718339223345b42935e9f4cbc7be208e557/DEPS#L552-L558).