Make sure to include the v8 version in autogenerated commit and PR description #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 95.59% 95.59%
=======================================
Files 16 16
Lines 545 545
=======================================
Hits 521 521
Misses 15 15
Partials 9 9 Continue to review full report at Codecov.
|
genevieve
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid confusion when the upgrade workflow runs, we can add the v8 version to the autogenerated PR, that way if we haven't merged one of the autogenerated PRs and the workflows runs and find a new stable version, we are going to be able to see which PR is the latest one.
Here is how the autogenerated PR looks like:
Ultimately, I think we could make the upgrade workflow to close any old upgrade PR that haven't been merged if a new stable v8 version is released.