Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build v8 for Apple Silicon #202

Merged
merged 11 commits into from
Oct 28, 2021
Merged

Build v8 for Apple Silicon #202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8394753
Build v8 for darwin_arm64
epk Oct 24, 2021
de01fba
./deps/build.py --arch arm64
epk Oct 24, 2021
e59012b
import rogchap.com/v8go/deps/darwin_arm64 in cgo.go
epk Oct 24, 2021
960dec5
Bump Go version
epk Oct 24, 2021
89d7ee9
revert to ubuntu-18.04
epk Oct 24, 2021
0e4fe11
PR comments
epk Oct 27, 2021
567e50b
update PR template to include arch
epk Oct 27, 2021
e063528
Revert "./deps/build.py --arch arm64"
dylanahsmith Oct 28, 2021
f3289dd
Update V8 static library for macos-11 arm64 (#216)
github-actions[bot] Oct 28, 2021
bfcd56f
Add changelog entry
dylanahsmith Oct 28, 2021
f4c24fb
Merge branch 'master' into epk/darwin_arm64
dylanahsmith Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bump Go version
  • Loading branch information
@epk @dylanahsmith
epk authored and dylanahsmith committed Oct 28, 2021
commit 960dec5ba2cb2495594e036f3a4ffbefc79647e7
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Tests on ${{ matrix.go-version }} ${{ matrix.platform }}
strategy:
matrix:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing the arch values for this pipeline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't test against darwin/arm64 without access to a M1 action runner

Run CGO_ENABLED=1 GOOS=darwin GOARCH=arm64 SDKROOT=$(xcrun --sdk macosx --show-sdk-path) go test -v -coverprofile c.out ./...
6
fork/exec /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/go-build300881077/b001/v8go.test: bad CPU type in executable
7
FAIL	rogchap.com/v8go	0.005s
8
?   	rogchap.com/v8go/deps/darwin_arm64	[no test files]
9
?   	rogchap.com/v8go/deps/darwin_x86_64	[no test files]
10
?   	rogchap.com/v8go/deps/include	[no test files]
11
?   	rogchap.com/v8go/deps/include/cppgc	[no test files]
12
?   	rogchap.com/v8go/deps/include/libplatform	[no test files]
13
?   	rogchap.com/v8go/deps/linux_x86_64	[no test files]
14
?   	rogchap.com/v8go/deps/windows_x86_64	[no test files]
15
FAIL

go-version: [1.12.17, 1.16.4]
go-version: [1.16.8, 1.17.1]
platform: [ubuntu-latest, macos-11, windows-latest]
epk marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ${{ matrix.platform }}

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module rogchap.com/v8go

go 1.12
go 1.16
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely a good idea to update to minimum of 1.16; but just making sure this will be ok for others? @dylanahsmith

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are on 1.17. I think we should support what Go itself supports, so 👍 to this change.