Rename failIf test helper to fatalIf since it uses t.Fatal #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 12 12
Lines 483 483
=======================================
Hits 460 460
Misses 14 14
Partials 9 9 Continue to review full report at Codecov.
|
dylanahsmith
force-pushed
the
fatal-if
branch
from
a0a5163 to
78a0fd9
Compare
genevieve
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The testing package has both t.Fail and t.Fatal, so calling the test helper method failIf makes it seem like it would call t.Fail and continue executing when it actually calls t.Fatal.
Solution
Renaming to fatalIf will make its behaviour clearer without looking at its implementation.